code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Event for withdraws is never emitted #313

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pedroais

Vulnerability details

Impact

Event for withdraws is never emitted

Proof of Concept

https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L132

There is an event called UserWithdrawn that should be emitted in withdrawals but it's never emitted.

cryptofish7 commented 2 years ago

Duplicate of #148

dmvt commented 2 years ago

Event issues are non-critical

0 — Non-critical (0): vulns have a risk of 0 and are considered “Non-critical” whenCode style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas-optimisations