search

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

!= 0 is cheaper than >0 for uint #318

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pedroais

Vulnerability details

Impact

!= 0 is cheaper than >0 for uint

Proof of Concept

https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L338

checking if a unit != 0 is cheaper and equivalent to checking if it's greater than 0 Mitigation Steps

cryptofish7 commented 2 years ago

Duplicate of #240