code-423n4 2022-01-xdefi-findings issues

code-423n4 / 2022-01-xdefi-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

`noReenter` gas optimization

#200 code423n4 closed 2 years ago
2
`destination_` zero address check

#199 code423n4 closed 2 years ago
2
_lock in noRenter can be optimized to use less gas

#198 code423n4 closed 2 years ago
2
Event for merge

#197 code423n4 opened 2 years ago
2
Improper event declaration

#196 code423n4 opened 2 years ago
2
`MAX_TOTAL_XDEFI_SUPPLY` missing `constant`

#195 code423n4 closed 2 years ago
2
"Safe" ERC20 functions for XDEFI?

#194 code423n4 opened 2 years ago
3
Possible profitability manipulations

#193 code423n4 opened 2 years ago
3
Math can be unchecked

#192 code423n4 closed 2 years ago
2
_generateNewTokenId can create collisions

#191 code423n4 closed 2 years ago
1
stale `_pointsPerUnit` if `updateDistribution` frequently

#190 code423n4 closed 2 years ago
2
During the merge positions of tokenId not deleted

#189 code423n4 closed 2 years ago
2
Use `calldata` instead of `memory` for function parameters

#188 code423n4 closed 2 years ago
2
A constant variable held in storage

#187 code423n4 closed 2 years ago
2
Change state only once in `noReenter` modifier

#186 code423n4 closed 2 years ago
2
Adding unchecked directive can save gas

#185 code423n4 opened 2 years ago
3
`updateDistribution()` can unexpectedly revert

#184 code423n4 closed 2 years ago
2
No option to unlock funds before set duration

#183 code423n4 opened 2 years ago
3
NFT is not burned during unlock

#182 code423n4 closed 2 years ago
2
EIP2612 is still draft

#181 code423n4 closed 2 years ago
2
Flash loans can be used to make deposits with 0 timelock

#180 code423n4 closed 2 years ago
2
Unnecessary require statement

#179 code423n4 opened 2 years ago
3
amount variables can be uint88

#178 code423n4 closed 2 years ago
2
Unnecessary casting

#177 code423n4 closed 2 years ago
2
MAX_TOTAL_XDEFI_SUPPLY can be constant

#176 code423n4 closed 2 years ago
2
confirm if lengths are equal before looping

#175 code423n4 closed 2 years ago
2
Use Infinite Approval

#174 code423n4 closed 2 years ago
2
Token IDs are not random

#173 code423n4 closed 2 years ago
1
Re-entracy leading to increasing points in undesired way

#172 code423n4 closed 2 years ago
1
Wrong revert message

#171 code423n4 opened 2 years ago
2
Use calldata arrays

#170 code423n4 closed 2 years ago
2
Declare `MAX_TOTAL_XDEFI_SUPPLY` as constant

#169 code423n4 closed 2 years ago
2
Missing 0-address checks in `proposeOwnership`

#168 code423n4 closed 2 years ago
1
Useless reentrancy guards

#167 code423n4 closed 2 years ago
2
Check `expiry` earlier can avoid unnecessary code execution when this check failed.

#166 code423n4 closed 2 years ago
2
Multi Transfer arrays length check

#165 code423n4 closed 2 years ago
2
XDEFIDistribution.sol noReenter: Switching between 1,2 instead of 0,1 is more gas efficient

#164 code423n4 closed 2 years ago
2
The Unchecked keyword can save gas

#163 code423n4 closed 2 years ago
2
Save Gas with the unchecked keyword

#162 code423n4 closed 2 years ago
2
> 0 can be replaced with != 0 for gas optimisation

#161 code423n4 closed 2 years ago
2
Public function that could be set external instead

#160 code423n4 closed 2 years ago
1
Reward system is prone to frontrunning/sandwitch attack

#159 code423n4 closed 2 years ago
1
Save Gas With The Unchecked Keyword (XDefiDistribution.sol)

#158 code423n4 closed 2 years ago
2
Its possible to have different bonusMultiplier for same lock duration

#157 code423n4 closed 2 years ago
2
Malicious early user/attacker can malfunction the contract and even freeze users' funds in edge cases

#156 code423n4 opened 2 years ago
4
Gas Optimization

#155 code423n4 closed 2 years ago
1
Avoiding unnecessary storage reads can save gas

#154 code423n4 closed 2 years ago
1
Should lock() and lockWithPermit() also call _updateXDEFIBalance()?

#153 code423n4 closed 2 years ago
2
Remove unnecessary variables can save gas

#152 code423n4 closed 2 years ago
2
`XDEFIDistribution.sol#_updateXDEFIBalance()` Avoiding unnecessary storage writes can save gas

#151 code423n4 opened 2 years ago
3