search

code-423n4 / 2022-01-xdefi-findings

0 stars 0 forks source link

XDEFIDistribution: make MAX_TOTAL_XDEFI_SUPPLY constant #42

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

GiveMeTestEther

Vulnerability details

Impact

Save gas by making storage variable constant that is never written.

Recommended Mitigation Steps

uint88 internal constant MAX_TOTAL_XDEFI_SUPPLY = uint88(240_000_000_000_000_000_000_000_000);

deluca-mike commented 2 years ago

Yup, good catch. However, we will be removing this variable anyway now.

deluca-mike commented 2 years ago

Duplicate #36