code-423n4 / 2022-01-yield-findings

1 stars 0 forks source link

Redundant `return` for named returns #117

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

Redundant code increase contract size and gas usage at deployment.

https://github.com/code-423n4/2022-01-yield/blob/e946f40239b33812e54fafc700eb2298df1a2579/contracts/ConvexStakingWrapper.sol#L310-L343

L342, return claimable is redundant.

Similar issue exists in L1LPTGateway.sol#getOutboundCalldata().

iamsahu commented 2 years ago

From readme:

alcueca commented 2 years ago

Duplicate of #60, which states a good reason to confirm this as a code quality issue, even if we don't care about the gas savings.