In the https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexYieldWrapper.sol#L67, the contract already make a storage pointer therefore any changes on vaults
will save it to the storage, remove vaults[account] = vaults; can save ~900 gas.
Handle
Fitraldys
Vulnerability details
Impact
In the
https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexYieldWrapper.sol#L67
, the contract already make a storage pointer therefore any changes on vaults will save it to the storage, remove vaults[account] = vaults; can save ~900 gas.Proof of Concept
https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexYieldWrapper.sol#L67 https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexYieldWrapper.sol#L93