code423n4 commented 2 years ago

Handle

throttle

Vulnerability details

Impact

Gas savings

Proof of Concept

Assigning default value costs unnecessary gas: ConvexStakingWrapper._calcCvxIntegral() ConvexStakingWrapper._calcRewardIntegral() ConvexStakingWrapper._checkpointAndClaim() ConvexStakingWrapper.earned() ConvexYieldWrapper.removeVault() ConvexYieldWrapper._getDepositedBalance()

Tools Used

Manual review

Recommended Mitigation Steps

Consider rewriting

for (uint256 i = 0; i < k; i++) {
    ...
}

to

for (uint256 i; i < k; i++) {
    ...
}

devtooligan commented 2 years ago

dup of #15

alcueca commented 2 years ago

Duplicate of #56, better

code-423n4 / 2022-01-yield-findings