Closed code423n4 closed 2 years ago
throttle
Gas savings
Reentrancy modifier is costly. Setting state variables to uint 0/1 is cheaper https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexStakingWrapper.sol#L54-L55
Manual review
Change to
uint256 private constant _NOT_ENTERED = 0; uint256 private constant _ENTERED = 1;
interesting
Duplicate of #96, that has a better solution
Handle
throttle
Vulnerability details
Impact
Gas savings
Proof of Concept
Reentrancy modifier is costly. Setting state variables to uint 0/1 is cheaper https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexStakingWrapper.sol#L54-L55
Tools Used
Manual review
Recommended Mitigation Steps
Change to