search

code-423n4 / 2022-01-yield-findings

1 stars 0 forks source link

Using ++i instead i++ for saving more gas #44

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Funen

Vulnerability details

Impact

Using i++ instead ++i for all the loops, the variable i is incremented using i++. It is known that implementation by using ++i costs less gas per iteration than i++.

POC

by seen the disscussion here : https://github.com/ethereum/solidity/issues/10695

Occurance

contracts/ConvexStakingWrapper.sol/L115:
contracts/ConvexStakingWrapper.sol/L287:
contracts/ConvexStakingWrapper.sol/L271:
contracts/ConvexStakingWrapper.sol/L315:
contracts/ConvexYieldWrapper.sol/L63:
contracts/ConvexYieldWrapper.sol/L80: contracts/ConvexYieldWrapper.sol/L111:

iamsahu commented 2 years ago

14 #50 #55 #59 #82 #97 #126

alcueca commented 2 years ago

Duplicate of #14