code-423n4 / 2022-01-yield-findings

1 stars 0 forks source link

`immutable` can saving more gas #48

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Funen

Vulnerability details

https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexStakingWrapper.sol#L41-L45

curveToken , convexToken , convexpool , collateralVault , convexPoolId comment was used immutable, but actual code not using immutable. immutable can saving more gas

Recommended Mitigation Steps

    address public curveToken;
    address public convexToken;
    address public convexPool;
    address public collateralVault;
    uint256 public convexPoolId;

changed to

    address public immutable curveToken;
    address public immutable convexToken;
    address public immutable convexPool;
    address public immutable collateralVault;
    uint256 public immutable convexPoolId;
devtooligan commented 2 years ago

dup of #42