code-423n4 / 2022-01-yield-findings

1 stars 0 forks source link

The visibility of ConvexYieldWrapper.removeVault should be changed to external. #71

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

ACai

Vulnerability details

Impact

The visibility of ConvexYieldWrapper.removeVault should be changed from public to external to reduce the gas consumption.

Proof of Concept

The visibility of ConvexYieldWrapper.removeVault should be changed from public to external, because they have not been called by other function in the same contract.

Tools Used

Recommended Mitigation Steps

In order to reduce gas consumption, the visibility of this function recommended to modify the public to external.

iamsahu commented 2 years ago

12