code-423n4 / 2022-01-yield-findings

1 stars 0 forks source link

++i is more gas efficient than i++ in loops forwarding #82

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

defsec

Vulnerability details

Impact

++i is more gas efficient than i++ in loops forwarding.

Proof of Concept

Navigate to the following contracts.

https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexYieldWrapper.sol#L111

Tools Used

Code Review

Recommended Mitigation Steps

It is recommend to use unchecked{++i} and change i declaration to uint256.

alcueca commented 2 years ago

Duplicate of #14