In the https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexModule.sol#L15 the addVault() take 2 parameters as input, convexStakingWrapper, and vaultId, however the convexStakingWrapper
is user controllable therefore the user could make an external call user controllable contract
Handle
Tomio
Vulnerability details
Impact
In the
https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexModule.sol#L15
the addVault() take 2 parameters as input, convexStakingWrapper, and vaultId, however the convexStakingWrapper is user controllable therefore the user could make an external call user controllable contractProof of Concept
https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexModule.sol#L15 https://github.com/code-423n4/2022-01-yield/blob/main/contracts/ConvexModule.sol#L27
Tools Used
Recommended Mitigation Steps