search

code-423n4 / 2022-02-concur-findings

2 stars 0 forks source link

QA Report #13

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

samruna

Vulnerability details

https://github.com/code-423n4/2022-02-concur/blob/main/contracts/StakingRewards.sol#L178

Setting 0 rewardDuration can cause malfuction and/or failure Add zero check for rewardDueration

GalloDaSballo commented 2 years ago

0 input -> Low Severity

JeeberC4 commented 2 years ago

Generating QA Report as warden did not submit one and judge downgraded issue. Preserving original title: setRewardDuration lack zero input validation

GalloDaSballo commented 2 years ago

All in all a couple of good finds, leaning towards gas / non-critical

GalloDaSballo commented 2 years ago

2