In withdraw function, Funds will stuck if user deposited a amount and then isDepositor[_depositor] is set to false by Admin. Now user cannot withdraw the amount since onlyDepositor will fail
Remediation: Withdraw should be independent of onlyDepositor
CloudEllie
commented
2 years ago
Judge @GalloDaSballo has assessed the 3rd item in QA Report #26 as Medium risk. The relevant finding follows:
…
Contract: https://github.com/code-423n4/2022-02-concur/blob/main/contracts/MasterChef.sol
In withdraw function, Funds will stuck if user deposited a amount and then isDepositor[_depositor] is set to false by Admin. Now user cannot withdraw the amount since onlyDepositor will fail
Remediation: Withdraw should be independent of onlyDepositor