QA Report

[code423n4]

QA report

• ConvexStakingWrapper
  1. non critical, _getTotalSupply() function name is quite misleading because it doesn’t actually get you the total supply but rather, it gets you the total number of tokens staked in the ConvexStakingWrapper contract.
  2. low, it is possible to avoid rounding errors when calculating d_reward in the _calcRewardIntegral() function by calculating the 20%, storing it in a local variable and then update d_rewards by subtracting this 20% away instead of the current d_reward = (d_reward * 4) / 5;
  3. low, deposit() function has a bad comment in the natspec. Fix should be @param _amount amount to deposit.
  4. low, as confirmed with leekt on discord, this comment //no-op for cvx, crv rewards in the addRewards() function is deprecated and should be removed.

[GalloDaSballo]

_getTotalSupply -> Non-critical

Rounding -> Agree

Comment -> Non-critical

Comment iv -> non-critical

Valuable report that ultimately helps the dev, just has very few findings, but I do appreciate the conciseness

[GalloDaSballo]

1+++