Open code423n4 opened 2 years ago
Repeated operations should be cached, e.g. amount.toInt256() is calculated twice:
require(margin[idx][trader] >= amount.toInt256(), "Insufficient balance"); margin[idx][trader] -= amount.toInt256();
++ is a bit cheaper:
i += 1;
'withdrawals' and 'start' state variables accessed multiple times in a loop should be cached before the loop:
while (i < withdrawals.length && (i - start) <= maxWithdrawalProcesses)
Duplicate of #21
Repeated operations should be cached, e.g. amount.toInt256() is calculated twice:
++ is a bit cheaper:
'withdrawals' and 'start' state variables accessed multiple times in a loop should be cached before the loop: