search

code-423n4 / 2022-02-jpyc-findings

1 stars 0 forks source link

Gas Optimizations #38

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago
  1. unnecessary 0 value set for uint256 because the default value is 0 https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v2/FiatTokenV2.sol#L58 https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v1/FiatTokenV1.sol#L58

remove 0 value

========================================================================

  1. considered using unchecked for gas efficient https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v2/FiatTokenV2.sol#L326-L327 https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v2/FiatTokenV2.sol#L381-L382 https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v1/FiatTokenV1.sol#L144-L146 https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v1/FiatTokenV1.sol#L316-L317

add unchecked

========================================================================

  1. considered remove false value for bool type because the default value of the bool is false https://github.com/code-423n4/2022-02-jpyc/blob/main/contracts/v1/Pausable.sol#L49

remove false

========================================================================