Use of Constants Improves Readability and Gas Performance
In the checkWhitelist function of the FiatTokenV2.sol file, the following function can be found:
modifier checkWhitelist(address _account, uint256 _value) {
if (_value > 100000 * 10 ** 18) {//@audit Gas Optimization This should be moved to constant or 1e18
require(
whitelisted[_account],
"Whitelistable: account is not whitelisted"
);
}
_;
}
Inside the if statement we have two things: a constant 100000 which is unexplained, and a 10**18 expression. Moving the 10**18 function to 1e18 or a constant would save on gas and be more readable.
Additionally, the use of 10000 instead of a constant like WHITELIST_LOWERBOUND or a similar constant would be more readable.
Use of Constants Improves Readability and Gas Performance
In the
checkWhitelistfunction of theFiatTokenV2.solfile, the following function can be found:Inside the
ifstatement we have two things: a constant100000which is unexplained, and a10**18expression. Moving the10**18function to1e18or a constant would save on gas and be more readable.Additionally, the use of
10000instead of a constant likeWHITELIST_LOWERBOUNDor a similar constant would be more readable.