Gas Optimizations

[code423n4]

GAS issues

1. Change the incremental logic from i++ to ++i in order to save some opcodes:

   • FeeSplitter.sol#L126
   • FeeSplitter.sol#L148
   • FeeSplitter.sol#L165
   • FeeSplitter.sol#L261
   • FeeSplitter.sol#L280
   • FeeSplitter.sol#L318
   • NestedRecords.sol#L196
   • OperatorResolver.sol#L40
   • OperatorResolver.sol#L60
   • OperatorResolver.sol#L75
   • MixinOperatorResolver.sol#L36
   • MixinOperatorResolver.sol#L55
   • NestedFactory.sol#L103
   • NestedFactory.sol#L113
   • NestedFactory.sol#L153
   • NestedFactory.sol#L213
   • NestedFactory.sol#L273
   • NestedFactory.sol#L291
   • NestedFactory.sol#L327
   • NestedFactory.sol#L369
   • NestedFactory.sol#L581

2. The following structs could be optimized moving the position of certains values in order to save slot storages:

   • Move fromReserve together inputToken
   • Move toReserve together outputToken

3. Use delete instead of set to default value (false or address(0))

   • OwnableFactoryHandler.sol#L37
   • Delete if destination it's equal to address(0) at OperatorResolver.sol#L63

4. Change the logic in order to save one variable

   • OwnableProxyDelegation.sol#L62-L66

    function _setOwner(address newOwner) private {
        emit OwnershipTransferred(_owner, newOwner);
        _owner = newOwner;
    }

[adrien-supizet]

1. already surfaced in first audit
2. duplicated https://github.com/code-423n4/2022-02-nested-findings/issues/28
3. Invalid, this makes no difference
4. acknowledged

[harleythedogC4]

My personal judgements:

1. "Change the incremental logic from i++ to ++i". Agree with sponsor. Invalid.
2. "The following structs could be optimized". I am going to disagree with the sponsor here, in theory there is an optimzation here, and obviously I can't reproduce the sponsor's claim of the gas costs actually increasing. I will mark as Valid and small-optimization.
3. "Use delete instead of set to default value". Agree with sponsor, according to here, it seems that there is no difference in this case. Invalid.
4. "Change the logic in order to save one variable". Valid and small-optimization

[harleythedogC4]

Now, here is the methodology I used for calculating a score for each gas report. I first assigned each submission to be either small-optimization (1 point), medium-optimization (5 points) or large-optimization (10 points), depending on how useful the optimization is. The score of a gas report is the sum of these points, divided by the maximum number of points achieved by a gas report. This maximum number was 10 points, achieved by #67.

The number of points achieved by this report is 2 points. Thus the final score of this gas report is (2/10)*100 = 20.