Gas Optimizations

[code423n4]

Gas Optimizations

Cache array length in for loops:

Caching the array length in a for-loop saves gas as the length does not need to be read on every iteration.

The following loops could be refactored:

• https://github.com/pooltogether/v4-twab-delegator/blob/master/contracts/Delegation.sol#L42
• https://github.com/pooltogether/v4-twab-delegator/blob/master/contracts/PermitAndMulticall.sol#L33

++i is more gas efficient than i++:

The following loops could be refactored:

• https://github.com/pooltogether/v4-twab-delegator/blob/master/contracts/Delegation.sol#L42
• https://github.com/pooltogether/v4-twab-delegator/blob/master/contracts/PermitAndMulticall.sol#L33

  remove return from _multicall():

  https://github.com/pooltogether/v4-twab-delegator/blob/master/contracts/PermitAndMulticall.sol#L36 _multicall() has named returns we can remove return results;

[PierrickGT]

Duplicate of https://github.com/code-423n4/2022-02-pooltogether-findings/issues/9, https://github.com/code-423n4/2022-02-pooltogether-findings/issues/14