search

code-423n4 / 2022-02-tribe-turbo-findings

1 stars 0 forks source link

Gas Optimizations #37

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboSafe.sol#L177 https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboSafe.sol#L212 https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboMaster.sol#L177 Add zero check for feiAmount. It'll save gas fees

https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboSafe.sol#L258 Add zero check for each of the amount fields. Only emit events or do further processing if the values are non zero. This will save a lot of gas fee.

https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboSafe.sol#L314 https://github.com/code-423n4/2022-02-tribe-turbo/blob/main/src/TurboSafe.sol#L336 Add zero check to amount to avoid gas fees

GalloDaSballo commented 2 years ago

Honestly this report is very poorly presented, the warden could have spent the time to explain their thinking instead of spitting one liners with links.

Am going to give it a 0/10