search

code-423n4 / 2022-02-tribe-turbo-findings

1 stars 0 forks source link

QA Report #71

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

TurboSafe: How do you account for potential losses ?

In case one of the boosted vaults has a loss, how would it be handled ? Currently, it would never lead to a reduction of the totalFeiBoosted, so the TurboSafe would have a "perpetual loss" and a debt towards the fuse pool, blocking withdrawals at a certain point.

Incorrect comment in TurboMaster- onSafeLess

Comment : https://github.com/code-423n4/2022-02-tribe-turbo/blob/66f27fe51083f49f7935e3fe594ab2380b75dee8/src/TurboMaster.sol#L248

This is incorrect because of https://github.com/code-423n4/2022-02-tribe-turbo/blob/66f27fe51083f49f7935e3fe594ab2380b75dee8/src/TurboSafe.sol#L230: at this step, feiAmount can differ from what was withdrawn from the safe, either because of fees accrued or because someone could repay the debt of the safe on its behalf for example.

GalloDaSballo commented 2 years ago

Agree with comment note

GalloDaSballo commented 2 years ago

1/10