code-423n4 / 2022-03-joyn-findings

4 stars 1 forks source link

transfer or transferFrom without checking the boolean result #141

Closed deluca-mike closed 2 years ago

deluca-mike commented 2 years ago

It was found some transfer, approve or transferFrom without checking the boolean result, ERC20 standard specify that the token can return false if this call was not made, so it's mandatory to check the result of approve methods.

deluca-mike commented 2 years ago

Duplicate of #52

deluca-mike commented 2 years ago

Folded back into #59.

Lacks nuance: it does not explain why this is specifically an issue in Joyn's contracts or provide and valid attack vectors.