Gas Optimizations

[code423n4]

• Function is declared as public but is only called externally. This occurs in a couple of instances:

• NXTPFacet: startBridgeTokensViaNXTP, swapAndStartBridgeTokensViaNXTP, completeBridgeTokensViaNXTP and swapAndCompleteBridgeTokensViaNXTP

• WithdrawFacet: withdraw

• GenericSwapFacet: swapTokensGeneric

• AnyswapFacet: swapAndStartBridgeTokensViaAnyswap, swapAndStartBridgeTokensViaAnyswap

• The unchecked block can be used for all the for loops. Consider adding an internal function _increment with an unchecked block and use it to increment the counter inside the for loop.

• LibAsset.decreaseERC20Allowance and LibAsset.increaseERC20Allowance are declared but never used

[H3xept]

Re: Public -> External -- Fixed in lifinance/lifi-contracts@26443af0142afdb131b6b3ab278fac29670b7b0e Duplicate of #197

[H3xept]

Re: unchecked -- We internally decided to avoid unchecked statements for now.

[H3xept]

Re. increaseERC20Allowance && decreaseERC20Allowance

Used in FulfillInterpreter.sol