Incorrect revert msg in NXTPFacet.completeBridgeTokensViaNXTP. In fact, the native token could be in different blockchain (e.g Polygone and the native token is MATIC)
The transfer ownership system ( OwnershipFacet )does not follow for transfer-accept patterns. Which may lead to contract ownership accidentally being mismanaged.
Recommendation: Implementing a transfer-accept pattern, or renouncing ownership of the contract may be preferred to countermeasure against mistaken ownership transfers.
it's better to replace the NATIVE_ASSET to another address rather than the address(0) to avoid any confusion that could happen (e.g WithdrawFacet.withdraw)
H3xept
commented
2 years ago
Incorrect revert msg in
NXTPFacet.completeBridgeTokensViaNXTP. In fact, the native token could be in different blockchain (e.g Polygone and the native token isMATIC)The transfer ownership system (
OwnershipFacet)does not follow for transfer-accept patterns. Which may lead to contract ownership accidentally being mismanaged. Recommendation: Implementing a transfer-accept pattern, or renouncing ownership of the contract may be preferred to countermeasure against mistaken ownership transfers.it's better to replace the
NATIVE_ASSETto another address rather than the address(0) to avoid any confusion that could happen (e.gWithdrawFacet.withdraw)All contracts use an unlocked pragma ^0.8.7.