search

code-423n4 / 2022-03-lifinance-findings

6 stars 4 forks source link

QA Report #148

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

1. wrong parameter used in LogWithdraw()

emit LogWithdraw(sendTo, _assetAddress, _amount);

first parameter should be asset address not the sendTo

`event LogWithdraw(address indexed _assetAddress, address _from, uint256 amount);`

it can affect the offchain monitoring tools or interfaces

https://github.com/code-423n4/2022-03-lifinance/blob/699c2305fcfb6fe8862b75b26d1d8a2f46a551e6/src/Facets/WithdrawFacet.sol#L37

H3xept commented 2 years ago

Fixed in lifinance/lifi-contracts@5a6fe3914d8f0eead632994332cc8c158dd57b29