code-423n4 / 2022-03-lifinance-findings

6 stars 4 forks source link

QA Report #153

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Missing Zero-address Validation

Description

The address can be set to address zero (0x00...) which could result in unexpected behavior.

Permalinks

  1. https://github.com/code-423n4/2022-03-lifinance/blob/699c2305fcfb6fe8862b75b26d1d8a2f46a551e6/src/Facets/CBridgeFacet.sol#L42

Mitigation

Setters of address type parameters should include a zero-address validation.

H3xept commented 2 years ago

Fixed in lifinance/lifi-contracts@84e7b13ad307b01d22b341a28df2d1c61c24a98f