QA Report - Githubissues

Inconsistency with approveERC20 function:

https://github.com/code-423n4/2022-03-lifinance/blob/699c2305fcfb6fe8862b75b26d1d8a2f46a551e6/src/Libraries/LibAsset.sol#L67
If a user already has the ERC20 approved with the DEX, the current code can lead to an error.
Specifically, if they've approved the DEX for X tokens previously (where X > 0), and then they request a swap for Y tokens (where Y > X), the result will be decreasing their allowance to 0.
Recommended Mitigation: use SafeERC20.safeIncreaseAllowance(IERC20(assetId), spender, MAX_INT) on this line instead.

code-423n4 / 2022-03-lifinance-findings