Gas Optimizations - Githubissues

code-423n4 / 2022-03-lifinance-findings

6 stars 4 forks source link

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Unnecessary Require Statement in Anyswap Facet:

https://github.com/code-423n4/2022-03-lifinance/blob/699c2305fcfb6fe8862b75b26d1d8a2f46a551e6/src/Facets/AnyswapFacet.sol#L105
We already verify address(this).balance - _fromBalance >= _anyswapData.amount, so we know it's > 0.
Recommended Improvement: Delete this line.

H3xept commented 2 years ago

Fixed in previous commit.