QA Report (Low / Non-Critical)

There is no zero address check in constructor function for the owner address in LiFiDiamond.sol
Usage of deprecated safeApprove. Link
Require statements are missing for addFunction() in LibDiamond.sol

Team can consider adding statements as;

require(_selector != 0, "Error msg here");
require(_facetAddress != address(0), "Error msg here");

Remove sol-hints on various locations.
Statement should be corrected to native asset rather than ether for correct guidance in LibAsset.sol#L42-L45
Remove bug related todo at WithdrawFacet.sol#L29
No amount check is carried out at LibAsset.sol inside transferNativeAsset()
enforceHasContractCode in LibDiamond.sol should not be relied on if the target is a contract inside the construction. Reference is here
Redundant if statement in LibDiamond.sol#196 since the statement is assumed as not succeeded.
Emit event at LibDiamond.sol#79 can be considered to be thrown after initializeDiamondCut function success.

code-423n4 / 2022-03-lifinance-findings