LOW AND NC for LIFI by PeritoFlores

Functions addDex and _removeDex lack of event emission

Functions addDex and _removeDex lack of event emission. So you are not aware if the dex was added/removed correctly from the whitelist . It is recommended to emit events. Maybe just after push/pop.

function addDex(address _dex) external {  //DexManagerFacet#L17
    LibDiamond.enforceIsContractOwner();

    if (s.dexWhitelist[_dex] == true) {
        return;
    }

    s.dexWhitelist[_dex] = true;
    s.dexs.push(_dex);  
    @audit  emit some event
}

function _removeDex(uint256 index) private { //DexManagerFacet#L17
    // Move the last element into the place to delete
    s.dexs[index] = s.dexs[s.dexs.length - 1];
    // Remove the last element
    s.dexs.pop(); 
    @audit emit some event 
    }

code-423n4 / 2022-03-lifinance-findings

QA Report #202

LOW AND NC for LIFI by PeritoFlores

Functions addDex and _removeDex lack of event emission