search

code-423n4 / 2022-03-paladin-findings

0 stars 0 forks source link

QA Report #12

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

l01:

HolyPaladinToken.constructor()._rewardsVault (contracts/HolyPaladinToken.sol#174) lacks a zero-check on :

            - rewardsVault = _rewardsVault (contracts/HolyPaladinToken.sol#194)

g05:

use small revert strings or use custom erros to save gas

Kogaroshi commented 2 years ago

QA & gas optimizations changes are done in the PR: https://github.com/PaladinFinance/Paladin-Tokenomics/pull/6 (some changes/tips were implemented, others are noted but won't be applied)