search

code-423n4 / 2022-03-paladin-findings

0 stars 0 forks source link

Gas Optimizations #39

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Issue 1 - Redundant requires

Detail

In the following code, the second block.timestamp require statement is more exclusive than the first, making the first redundant.

Code

https://github.com/code-423n4/2022-03-paladin/blob/9c26ec8556298fb1dc3cf71f471aadad3a5c74a0/contracts/HolyPaladinToken.sol#L1280-L1283

Kogaroshi commented 2 years ago

This is wanted, to allow the user (or the devs) to know why the Lock could not be kicked, based on the current timestamp.