search

code-423n4 / 2022-03-paladin-findings

0 stars 0 forks source link

QA Report #51

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago
  1. Typo comments

https://github.com/code-423n4/2022-03-paladin/blob/9c26ec8556298fb1dc3cf71f471aadad3a5c74a0/contracts/HolyPaladinToken.sol#L113 https://github.com/code-423n4/2022-03-paladin/blob/9c26ec8556298fb1dc3cf71f471aadad3a5c74a0/contracts/HolyPaladinToken.sol#L117

POC

comment was using distriubted was set (this typo), it should be distributed

Tool Used

Manual Review

Recommended Mitigation

change to distributed

Kogaroshi commented 2 years ago

QA & gas optimizations changes are done in the PR: https://github.com/PaladinFinance/Paladin-Tokenomics/pull/6 (some changes/tips were implemented, others are noted but won't be applied)