search

code-423n4 / 2022-03-prepo-findings

0 stars 0 forks source link

QA Report #19

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

No need to wrap with parenthesis

Target codebase

_valueBefore variable is wrapped by parenthesis but this is not needed.

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/Collateral.sol#L89

_shares = (_amountToDeposit * totalSupply()) / (_valueBefore);

Proposed change

_shares = (_amountToDeposit * totalSupply()) / _valueBefore;
ramenforbreakfast commented 2 years ago

Valid claim, but lower severity to 0. Does not affect functionality and is a code style nit.

ramenforbreakfast commented 2 years ago

Ignore mentions, accidentally referred to issue 19 when i meant 18 for duplicate issues.