code-423n4 / 2022-03-rolla-findings

1 stars 1 forks source link

QA Report #56

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

L-01: Missing Zero check

QuantCalculator.constructor(contracts/QuantCalculator.sol#55) lacks a zero-check on : optionsFactory = _optionsFactory (contracts/QuantCalculator.sol#57)

L-02: Ether lock

Payable function with no method of withdrawal available, eventually ends up locking ether

executeMetaTransaction() (contracts/utils/EIP712MetaTransaction.sol#55-93)