code-423n4 / 2022-03-volt-findings

0 stars 0 forks source link

Division by zero in `isWithinDeviationThreshold` #127

Closed CloudEllie closed 2 years ago

CloudEllie commented 2 years ago

Judge @jack-the-pug is upgrading the following issue from a QA report (issue #30 ) to Medium risk:

Division by zero in isWithinDeviationThreshold if a is zero. This only seems to be the case if the oracle would return 0 for CPI and in this case, something is wrong anyway. Should still handle this error more gracefully.

CloudEllie commented 2 years ago

Duplicate of #58

jack-the-pug commented 2 years ago

Confirmed! Thanks @CloudEllie