The overall quality of the Volt codebase is excellent. The modular architecture is very clear. Codes are very well documented, with additional explanatory comments when necessary. Tests are comprehensive and cover critical modules. Consider adding tests for external library functions such as BokkyPooBahsDateTimeContract.getDay().
Low Severity Findings:
Missing sync capabilities in CoreRef.
Governance can set a new vcon token address via Core.setVcon, while CoreRef._vcon can only be set once in the constructor. Therefore, setting a new vcon address will lead to inaccurate state in all contracts that inherit CoreRef. Consider adding a sync function to fetch the new vcon address from Core.
The overall quality of the Volt codebase is excellent. The modular architecture is very clear. Codes are very well documented, with additional explanatory comments when necessary. Tests are comprehensive and cover critical modules. Consider adding tests for external library functions such as
BokkyPooBahsDateTimeContract.getDay().Low Severity Findings:
CoreRef. Governance can set a new vcon token address viaCore.setVcon, whileCoreRef._vconcan only be set once in the constructor. Therefore, setting a new vcon address will lead to inaccurate state in all contracts that inherit CoreRef. Consider adding a sync function to fetch the new vcon address from Core.Non-critical Findings: