search

code-423n4 / 2022-03-volt-findings

0 stars 0 forks source link

Wrong modfier #95

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-03-volt/blob/f1210bf3151095e4d371c9e9d7682d9031860bbd/contracts/oracle/OraclePassThrough.sol#L56

Vulnerability details

Impact

According to the comment at line #49 and the business logic of this smart contract, it is better to use "IS_governer " or "onlyGoverner" modifier instead of "onlyOwner".

Proof of Concept

Tools Used : manual analysis

Recommended Mitigation Steps

changing modefier

ElliotFriedman commented 2 years ago

OraclePassThrough is created as an owned contract with FRAX and VOLT on the multisig