search

code-423n4 / 2022-04-abranft-findings

0 stars 0 forks source link

QA Report #121

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

QA Report

Table of content

QA Findings

Multiplication instead division in compares

Division causes ceiling and therefore loss of precision. In the other hand multiplication does not. In the following situations you can rearange the equation to use multiplication instead of division.

Missing fee parameter validation

The fee parameter need to be validated since otherwise you may allow it to be 0 fee. And fee that is over 100% for example is also probably a mistake that can happen with the decimals.

cryptolyndon commented 2 years ago

EDIT The "fee over 100%" comment, that has nothing to do with the lines, reappears in #123. Suspect this person is trying to cheat. See #124