search

code-423n4 / 2022-04-abranft-findings

0 stars 0 forks source link

QA Report #159

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago
  1. Title : Typo Comment

This was typo comment, it should be calculateinterest instead of calculateIntest.

Tool Used

Manual Review

  1. Title : Consistency code for easy readibilty

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L188-L191

since this worse params was used, it can be used like below :

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L283-L288

Tool Used

Manual Review

Recommended Mitigation

            require(
                params.duration >= cur.duration &&
                params.valuation <= cur.valuation &&
                params.annualInterestBPS <= cur.annualInterestBPS,
                "NFTPair: worse params"
            );
cryptolyndon commented 2 years ago

The "bad params" and "worse params" messages are different checks. Why make the revert string the same?