search

code-423n4 / 2022-04-backd-findings

6 stars 4 forks source link

QA Report #130

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Non-Critical

Upgrade Solidity Version

Consider to pin Solidity version to latest 0.8.12

Unresolved TODOs

contracts/strategies/ConvexStrategyBase.sol:4:// TODO Add validation of curve pools
contracts/strategies/ConvexStrategyBase.sol:5:// TODO Test validation
contracts/actions/topup/TopUpAction.sol:713:        // TODO: add constant gas consumed for transfer and tx prologue

Use custom errors

Solidity ^0.8.4 allow the use of custom errors to optimize gas usage. https://blog.soliditylang.org/2021/04/21/custom-errors/

contracts/strategies/ConvexStrategyBase.sol:198:        require(communityReserve != address(0), "Community reserve must be set");
contracts/strategies/ConvexStrategyBase.sol:215:        require(communityReserve != address(0), "Community reserve must be set");
contracts/strategies/StrategySwapper.sol:69:            require(sent, "failed to send eth");
contracts/BkdLocker.sol:136:        require(length > 0, "No entries");
gzeoneth commented 2 years ago

Submitted by contest judge.