code-423n4 / 2022-04-backd-findings

6 stars 4 forks source link

Account is not removed from _roleMembers[role] #145

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/access/RoleManager.sol#L155

_revokeRole: Account is not removed from _roleMembers[role] which impacts getRoleMemberCount as it will give removed account count as well

chase-manning commented 2 years ago

I consider this report to be of particularly high quality

gzeoneth commented 2 years ago

Changing to standalone issue, duplicate of #164.