code-423n4 / 2022-04-backd-findings

6 stars 4 forks source link

Gas Optimizations #163

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

001e18 should not be used instad be used in long version to save gas https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/strategies/BkdTriHopCvx.sol https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/actions/topup/TopUpAction.sol https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/vault/Vault.sol https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/pool/LiquidityPool.sol https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/strategies/BkdEthCvx.sol

https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/StakerVault.sol

Lp_gaude does not have big Bytes32 Approve function not needed just made msg.sender

https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/pool/PoolFactory.sol Make it decimals uint256 doesn't matter. LpTokenArgs _addImplementation Function del from storage impletation

https://github.com/code-423n4/2022-04-backd/blob/main/backd/contracts/access/RoleManager.sol mapping(address => bool) members; Waste of gas bool just use uint