code-423n4 / 2022-04-backd-findings

6 stars 4 forks source link

Gas Optimizations #175

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Issue #1 - Adding require that currentBalance > 0 earlier in function will save gas

https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/GasBank.sol#L47-L49

Issue #2 - Multiple requires requires less gas than &&

https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/actions/topup/TopUpAction.sol#L676

https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/strategies/ConvexStrategyBase.sol#L273-L276