transfer is used for transfering ether - Githubissues

code-423n4 / 2022-04-backd-findings

6 stars 4 forks source link

transfer is used for transfering ether #218

Closed gzeoneth closed 2 years ago

gzeoneth commented 2 years ago

Originally submitted by warden pauliax in https://github.com/code-423n4/2022-04-backd-findings/issues/173, duplicate of https://github.com/code-423n4/2022-04-backd-findings/issues/52.

.transfer is used for transfering ether, e.g.:
```
    payable(to).transfer(amount);
    payable(msg.sender).transfer(amount);
```
It is currently not recommended as recipients with custom fallback functions (smart contracts) will not be able to handle that. You can read more here: https://consensys.net/diligence/blog/2019/09/stop-using-soliditys-transfer-now/

Solution (don't forget re-entrancy protection): https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol#L53-L59