search

code-423n4 / 2022-04-badger-citadel-findings

0 stars 1 forks source link

QA Report #161

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Low Risk

tokenOutPrice can be decreased but earlier buyer still pay the higher price

https://github.com/code-423n4/2022-04-badger-citadel/blob/18f8c392b6fc303fe95602eba6303725023e53da/src/KnightingRound.sol#L336

Non-Critical

Allow buy maximum amount when exceeding total amount in KnightingRound

https://github.com/code-423n4/2022-04-badger-citadel/blob/18f8c392b6fc303fe95602eba6303725023e53da/src/KnightingRound.sol#L174

Unresolved TODOs

./src/SupplySchedule.sol:159:        // TODO: Require this epoch is in the future. What happens if no data is set? (It just fails to mint until set)
./src/Funding.sol:15: * TODO: Better revert strings
./src/Funding.sol:61:    // TODO: we should conform to some interface here
./src/Funding.sol:183:        // TODO: Check gas costs. How does this relate to market buying if you do want to deposit to xCTDL?
./src/KnightingRound.sol:14: * TODO: Better revert strings
./src/GlobalAccessControl.sol:106:    /// TODO: Add string -> hash EnumerableSet to a new RoleRegistry contract for easy on-chain viewing.