In the getAmountOut function of Funding.sol, if citadelPriceInAsset is not set (equal to 0) then citadelAmountWithoutDiscount will equal 0 and the getAmountOut function will return 0.
When getAmountOut is called in deposit, citadelAmount_ will be equal to 0. If the _minCitadelOut parameter in deposit is set to more than 0, the require on line 178 would fail, not allowing a user to deposit. If _minCitadelOut is set to 0 then the require condition would be passed. However, when depositFor is called on line 184 the transaction will fail due to the amount in depositFor being equal to 0.
Without the citadelPriceInAsset value being set, users would not be able to use deposit.
A possible fix would be to set the citadelPriceInAsset value before calculating citadelAmountWithoutDiscount in getAmountOut.
N-01: Error in comments for deposit function in Funding.sol
The comment describes the parameter _minCitadelOut as 'ID of DAO to vote for' and should instead be something along the lines of 'minimum CTDL tokens to be received'.
L-01: No
citadelPriceInAssetvalue check might lead to unintendeddepositfunctionality inFunding.solLine References
Description
In the
getAmountOutfunction ofFunding.sol, ifcitadelPriceInAssetis not set (equal to 0) thencitadelAmountWithoutDiscountwill equal 0 and thegetAmountOutfunction will return 0.When
getAmountOutis called indeposit,citadelAmount_will be equal to 0. If the_minCitadelOutparameter indepositis set to more than 0, the require on line 178 would fail, not allowing a user to deposit. If_minCitadelOutis set to 0 then the require condition would be passed. However, whendepositForis called on line 184 the transaction will fail due to the amount indepositForbeing equal to 0.Without the
citadelPriceInAssetvalue being set, users would not be able to usedeposit.A possible fix would be to set the
citadelPriceInAssetvalue before calculatingcitadelAmountWithoutDiscountingetAmountOut.N-01: Error in comments for
depositfunction inFunding.solLine References
Description
The comment describes the parameter
_minCitadelOutas 'ID of DAO to vote for' and should instead be something along the lines of 'minimum CTDL tokens to be received'.