search

code-423n4 / 2022-04-badger-citadel-findings

0 stars 1 forks source link

Gas Optimizations #209

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Issue 1 - Move require to top of function to avoid unnecessary state changes

https://github.com/code-423n4/2022-04-badger-citadel/blob/18f8c392b6fc303fe95602eba6303725023e53da/src/CitadelMinter.sol#L368-L371

Issue 2 - assetDecimalsNormalizationValue can be made immutable

https://github.com/code-423n4/2022-04-badger-citadel/blob/18f8c392b6fc303fe95602eba6303725023e53da/src/Funding.sol#L41

https://github.com/code-423n4/2022-04-badger-citadel/blob/18f8c392b6fc303fe95602eba6303725023e53da/src/KnightingRound.sol#L63